-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SchemaUtils Nested Map Fix #499
Merged
adamreeve
merged 8 commits into
G-Research:master
from
jescalada:jescalada-schemautils-nested-map-fix
Jan 24, 2025
Merged
SchemaUtils Nested Map Fix #499
adamreeve
merged 8 commits into
G-Research:master
from
jescalada:jescalada-schemautils-nested-map-fix
Jan 24, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamreeve
requested changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good thanks Juan, I just have some comments about the test
Co-authored-by: Adam Reeve <[email protected]>
….com/jescalada/ParquetSharp into jescalada-schemautils-nested-map-fix
adamreeve
reviewed
Jan 24, 2025
adamreeve
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where files generated by 3rd-party tools (with nonstandard schemas) fail to read correctly.
Let me know if the new test is comprehensive enough. I tried to add another test by generating a nested schema recursively, but this would require modifying
DoRoundtripTest
by changing the keys/values from 2D to 3D arrays.This was the schema generation function I thought of, but I don't know if this is overkill for our purposes.